Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CTM Glowing Textures #1218

Open
jredfox opened this issue Feb 14, 2018 · 3 comments
Open

Support CTM Glowing Textures #1218

jredfox opened this issue Feb 14, 2018 · 3 comments

Comments

@jredfox
Copy link

jredfox commented Feb 14, 2018

It's incompatible with CTM glowing textures and possible even it's main use. I saw your other post it is possible with forge as they have already done it please take a look at this. The link below is the page to the site and the curseforge has the source link

Curseforge:
https://minecraft.curseforge.com/projects/ctm

@jredfox jredfox changed the title Support CTM Support CTM Glowing Textures Feb 14, 2018
@sp614x
Copy link
Owner

sp614x commented Feb 14, 2018

If I understand correctly the problem is this: #631
OptiFine disables the Forge Lighting Pipeline because it breaks way too many OptiFine features. There is an issue about making the lighting pipeline compatible with OptiFine: MinecraftForge/MinecraftForge#3091.
The Chisel CTM uses a side effect of the Forge Lighting Pipeline to make glowing textures. I tried to add support for custom light values, but Forge replaces the original light values with fake pre-baked light so the custom light values don't reach OptiFine.

@jredfox
Copy link
Author

jredfox commented Feb 14, 2018

How about on client side you change the lightmap values of minecraft itself or is that a different thing a bit confused here.

@sp614x
Copy link
Owner

sp614x commented Feb 14, 2018

It is complicated, this is why it is not fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants