Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve packages test #270

Merged
merged 3 commits into from Jun 16, 2019

Conversation

Projects
None yet
2 participants
@eahlberg
Copy link
Collaborator

commented Jun 16, 2019

Description of the change

Improve packages test by:

  • using a fixture in the test which checks for missing packages
  • using a fixture in the test which checks for circular dependencies

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

@f-f f-f merged commit 99ae8e8 into spacchetti:master Jun 16, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

elliotdavies pushed a commit to elliotdavies/spago that referenced this pull request Jul 1, 2019

Improve packages test (spacchetti#270)
* Fix typo

* Use a fixture when testing missing dependencies

* Add test for checking circular dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.