Cross-Platform Update #42
Merged
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Windows-specific config.json parsing statement to work on non-Windows systems.
|
I'm converting this to a draft because I may have run into another issue on linux, but I need to test and make sure it is not being caused by a different mod. |
|
Can confirm this fixes the error |
This comment was marked as resolved.
This comment was marked as resolved.
|
This PR now relies on space-commits/SPT-Realism-Mod-Client#54 All of the above errors and the lack of F12 menu are fixed on both Windows and Linux servers. I'd love some testing feedback to make sure before I convert this from a draft to a full PR. |
JeffreyBytes
changed the title
|
I would also like to suggest building the server files without the I can make these changes as part of this PR if you'd like, Fontaine. I don't want to overstep the project scope. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing method for config.json was specifically written for Windows systems and was causing issues on non-Windows systems (such as in a Docker container). Replaced Windows-specific parsing statement to also work on non-Windows systems.
NOTE: The JavaScript files were not updated, so a new build will need to be done before merging. If you aren't aware, SPT does not recommend bundling the JavaScript files anymore to be more platform-agnostic.
I've allowed edits by maintainers, so please feel free to make changes to my branch if needed.