Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managed nodes with lifecycle nodes #29

Merged
merged 26 commits into from
Jul 19, 2024
Merged

managed nodes with lifecycle nodes #29

merged 26 commits into from
Jul 19, 2024

Conversation

Nicaus
Copy link
Contributor

@Nicaus Nicaus commented Jun 18, 2024

to view lifecycle node state, execute:

ros2 lifecycle get /[node_name]

if it says active, everything should be running as usual

To kill nodes, execute:

ros2 lifecycle set /[node_name] shutdown

@Nicaus Nicaus requested a review from OZiad June 20, 2024 05:41
.vscode/settings.json Outdated Show resolved Hide resolved
src/wheels_controller/src/wheels_controller_node.h Outdated Show resolved Hide resolved
launch/robot_wheels.py Outdated Show resolved Hide resolved
launch/robot_wheels.py Outdated Show resolved Hide resolved
src/gps/src/gpsPublisherNode.h Show resolved Hide resolved
src/gps/src/gpsServiceClientNode.cpp Outdated Show resolved Hide resolved
src/service_client/src/service_client.cpp Outdated Show resolved Hide resolved
src/sil/src/SIL_color_publisher_node.cpp Outdated Show resolved Hide resolved
src/wheels_controller/src/wheels_controller_node.cpp Outdated Show resolved Hide resolved
public:
Absenc();
~Absenc();
callbackReturn on_configure(const rclcpp_lifecycle::State &);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: include parameter name in header file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by that?

callbackReturn on_configure(const rclcpp_lifecycle::State &);
callbackReturn on_activate(const rclcpp_lifecycle::State & state);
callbackReturn on_deactivate(const rclcpp_lifecycle::State & state);
callbackReturn on_cleanup(const rclcpp_lifecycle::State &);
Copy link
Contributor

@OZiad OZiad Jul 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above here

src/absenc_interface/src/absenc.h Outdated Show resolved Hide resolved
src/absenc_interface/src/absenc_node.cpp Outdated Show resolved Hide resolved
src/arm_controller/src/arm_controller_node.cpp Outdated Show resolved Hide resolved
src/gps/src/gpsPublisherNode.h Outdated Show resolved Hide resolved
@OZiad OZiad merged commit 044d766 into main Jul 19, 2024
@OZiad OZiad deleted the managed-1 branch July 19, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants