Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI to run vcstool outside the Docker image #60

Open
EzraBrooks opened this issue Jul 27, 2023 · 3 comments
Open

Refactor CI to run vcstool outside the Docker image #60

EzraBrooks opened this issue Jul 27, 2023 · 3 comments
Assignees

Comments

@EzraBrooks
Copy link
Member

using vcs, or other methods of using Git, inside your Dockerfile causes all sorts of disk space and caching shenanigans.

@Bckempa
Copy link
Contributor

Bckempa commented Dec 3, 2023

Preliminarily nominating this for next release as part of a planned revision of the existing docker files. If it doesn't make it as part of that clean-up effort it can be descoped.

@EzraBrooks EzraBrooks self-assigned this Dec 14, 2023
@xfiderek
Copy link
Contributor

Which CI workflow and docker image are we refering to? Is it this one:
https://github.com/space-ros/docker/blob/main/.github/workflows/earthly-build.yaml

@EzraBrooks
Copy link
Member Author

No, this is about removing invocations of vcs from inside Dockerfiles throughout the repository and instead calling it externally to avoid filling the Docker image up with Git metadata and having idempotency issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants