Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the space_robots workflow to run the demo simulations #67

Open
mkhansenbot opened this issue Aug 10, 2023 · 3 comments
Open

Update the space_robots workflow to run the demo simulations #67

mkhansenbot opened this issue Aug 10, 2023 · 3 comments
Assignees

Comments

@mkhansenbot
Copy link
Contributor

I'm not sure if this is possible in GHA, but ideally, we should have a test that runs the demos by using the run.sh script to start a headless simulation in gazebo.

@ivanperez-keera
Copy link
Contributor

I would love to see that happen. I didn't even think about running it headless.

That being said, it looks like this could be non-trivial (and please correct me if I'm wrong). Especially detecting that it's running correctly, since there is no clear end condition.

What do you guys think about making some of the less clear issues (or the ones where it's less clear if we'll have the time/resources to do it) to discussions, to keep the issues list a bit shorter and more manageable?

@Bckempa
Copy link
Contributor

Bckempa commented Jan 15, 2024

While testing for "correctness" could definitely be a rabbit-hole, smoke-testing that the sim can start-up cleanly is definitely well-scoped for a ticket and would significantly improve the types of errors we can catch in CI. I think we should take this on for the April release.

@mkhansenbot mkhansenbot added this to the humble-2024.04.0 milestone Jan 30, 2024
@mkhansenbot
Copy link
Contributor Author

Added to next milestone (proposed) humble-2024.04.0

@mkhansenbot mkhansenbot removed this from the humble-2024.04.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants