Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate all sources of memory allocation in the talker/listener demos #44

Open
wjwwood opened this issue May 11, 2022 · 1 comment
Open

Comments

@wjwwood
Copy link

wjwwood commented May 11, 2022

In order to help us catalogue and address (whether that be by making sure its allocator can be overridden properly or by eliminating it for upstream ROS 2 or just Space ROS) all the sources of memory allocation in those two demos, we need to enumerate them first.

Use things like https://github.com/osrf/osrf_testing_tools_cpp#memory_tools to find all allocations and perhaps categorize them so we can reason about what needs to be done for each.

Definition of Done for this task is a list of all memory allocations for the talker and listener applications (C++) in the demo_nodes_cpp package, with optional categorization as it makes sense.

We'll use gcc and Ubuntu Linux 20.04 (maybe 22.04 @nuclearsandwich?) as that may affect what the std library will do based on its version.

Also, we could look at the call trace and check the API docs of all the system calls and std library calls made to ensure they shouldn't allocate memory in corner cases either.

@wjwwood wjwwood added the Memory Allocation Tasks related to making memory allocation safer label May 11, 2022
@nuclearsandwich
Copy link

We'll use gcc and Ubuntu Linux 20.04 (maybe 22.04 @nuclearsandwich?) as that may affect what the std library will do based on its version.

We haven't yet migrated the Space ROS docker images to 22.04 nor the Space ROS repos file to the Humble release (instead of tracking Rolling development) but I think that forward planning should use 22.04 as the base. I will support that with image updates where I can.

@mjeronimo mjeronimo removed the Memory Allocation Tasks related to making memory allocation safer label May 16, 2023
eholum pushed a commit to eholum/space-ros that referenced this issue Jun 9, 2024
…os#50)

Fixes space-ros#44.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
eholum pushed a commit to eholum/space-ros that referenced this issue Jun 9, 2024
…os#50)

Fixes space-ros#44.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants