Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service worker? #2

Open
dbrgn opened this issue Apr 14, 2024 · 0 comments
Open

Remove service worker? #2

dbrgn opened this issue Apr 14, 2024 · 0 comments

Comments

@dbrgn
Copy link

dbrgn commented Apr 14, 2024

The validator contains a service worker: https://github.com/spaceapi-community/validator-web/blob/master/src/serviceWorker.js

This makes it a PWA and provides offline support. However, since we need to call the upstream validator endpoint, offline support is quite useless for us. On the other hand, the service worker adds complexity and potential for subtle caching bugs. (I've fought with buggy cache invalidation in service workers before, and it's not very pleasant.)

I assume the SW is only in there because it's part of some react template. Any reasons not to remove the service worker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant