-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct Messages and other fixes #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can you explain what you doing with Recipient.closed
?
It's needed to fix #365, if a user close a dm channel in the client we need to set it as closed to prevent sending the channel in the READY event, this way it doesn't reappear in the gui until the user reopen it by trying to send a DM to the other recipient |
Everything should work now, the only problem is that the gateway doesn't properly remove listener but it does that for everything not only DMs |
Then we can merge the PR and work on the fix in another one |
Done:
users
TODO:
In util i also added service and dto layers to keep the code cleaner