Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix CI build #1

Merged
merged 3 commits into from May 21, 2022
Merged

feat: Fix CI build #1

merged 3 commits into from May 21, 2022

Conversation

Hebilicious
Copy link
Contributor

Congratulations on the launch !

Just a couple CI things :

  • Uses setup-node v3 that has cache by default
  • Uses npm over yarn since your package.json uses npm

@Hebilicious
Copy link
Contributor Author

Hebilicious commented May 20, 2022

All things considered, running cabal build contract in CI is really long... Hopefully with docker layering it won't be rebuilding everything from scratch all the time and will be faster on the next runs.

Interestingly, I run into these issues both locally and with Docker (official Haskell image:8.10.7) :

/github/home/.cabal/store/ghc-8.10.7/cardano-crypto-praos-2.0.0-47a84806569723d0fe6d09ca91fbc1e7f30f1a056874cfa58ce1a4ae6c15a037/lib/libHScardano-crypto-praos-2.0.0-47a84806569723d0fe6d09ca91fbc1e7f30f1a056874cfa58ce1a4ae6c15a037.a(Praos.o):ghc_3.c:function cardanozmcryptozmpraoszm2zi0zi0zm47a84806569723d0fe6d09ca91fbc1e7f30f1a056874cfa58ce1a4ae6c15a037_CardanoziCryptoziVRFziPraos_zdwskFromBytes_info: error: undefined reference to 'crypto_vrf_secretkeybytes'
collect2: error: ld returned 1 exit status
`gcc' failed in phase `Linker'. (Exit code: 1)

@alessandrokonrad
Copy link
Contributor

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@Hebilicious
Copy link
Contributor Author

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@alessandrokonrad I can comment out the Haskell build until I figure out what's going on... Can't get it to work on Docker or on MacOS 🤔

@alessandrokonrad
Copy link
Contributor

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@alessandrokonrad I can comment out the Haskell build until I figure out what's going on... Can't get it to work on Docker or on MacOS 🤔

Yeah that would be a good idea👍🏻

@Hebilicious
Copy link
Contributor Author

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@alessandrokonrad I can comment out the Haskell build until I figure out what's going on... Can't get it to work on Docker or on MacOS 🤔

Yeah that would be a good idea👍🏻

I've commented out the on-chain build, this should be good to merge 🚀

@alessandrokonrad alessandrokonrad merged commit f363adc into spacebudz:main May 21, 2022
@Hebilicious
Copy link
Contributor Author

Hebilicious commented May 21, 2022

@alessandrokonrad Btw, I wanted to know if you have managed/tried to build locally without nix ?

I also have started working on a plutus standard for NFTs, opened an issue here to let you know.
Might be easier to DM, my discord is Hebilicious#3910

@alessandrokonrad
Copy link
Contributor

@alessandrokonrad Btw, I wanted to know if you have managed/tried to build locally without nix ?

I do not use nix here. You only need cabal and ghc.

I also have started working on a plutus standard for NFTs, opened an issue berry-pool/nft-plutus#1 to let you know.
Might be easier to DM, my discord is Hebilicious#3910

Cool I'll take a look and will DM you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants