Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send error on invalid unsubscribe request #920

Closed
HeyItsJs opened this issue Apr 8, 2020 · 1 comment
Closed

Send error on invalid unsubscribe request #920

HeyItsJs opened this issue Apr 8, 2020 · 1 comment
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@HeyItsJs
Copy link
Contributor

HeyItsJs commented Apr 8, 2020

Right now, if we send an invalid subscribe request (request without dbType) via space-api-js, then Space Cloud sends an ack true even though it did not find any such subscription object. This gives a false indication that unsubscribe operation was successful even though it was not. Sending an invalid subscribe request is a bug of client API. However, Space Cloud should send error on such invalid requests rather than silently ignoring such errors and sending positive ack so that such problems can be detected and solved earlier.

@HeyItsJs HeyItsJs added 🐛 bug Something isn't working backend labels Apr 8, 2020
@HeyItsJs HeyItsJs added this to the v0.17.0 milestone Apr 8, 2020
@YourTechBud
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants