space-cli commands to view, change and delete accounts #1024

KavishShah09 · 2020-05-23T12:59:15Z

Fixes #1021

space-cli/cmd/modules/accounts/view.go

space-cli/cmd/modules/accounts/commands.go

…into accounts-crud

space-cli/cmd/modules/accounts/set.go

space-cli/cmd/utils/file.go

sharadregoti

@YourTechBud do you still want to implement the edit command according to the issue #1021
@KavishShah09 Add test files

space-cli/cmd/modules/accounts/commands.go

space-cli/cmd/modules/accounts/delete.go

space-cli/cmd/modules/accounts/set.go

space-cli/cmd/modules/accounts/view.go

YourTechBud · 2020-05-26T16:34:48Z

@sharadregoti Lets leave the edit command for later

space-cli/cmd/modules/accounts/set.go

space-cli/cmd/modules/accounts/view.go

…into accounts-crud

space-cli/cmd/modules/accounts/commands.go

space-cli/cmd/modules/accounts/delete.go

space-cli/cmd/modules/accounts/delete_test.go

space-cli/cmd/modules/accounts/set.go

space-cli/cmd/modules/accounts/set_test.go

space-cli/cmd/modules/accounts/set.go

space-cli/cmd/modules/accounts/view.go

…into accounts-crud

sharadregoti · 2020-06-05T02:23:43Z

Task linked: CU-5rjr1w Space CLI Command For Accoutns.yaml

space-cli/cmd/modules/accounts/view.go

space-cli/cmd/modules/accounts/commands.go

outdated

accounts view command

c8a52fd

YourTechBud requested changes May 23, 2020

View reviewed changes

space-cli/cmd/modules/accounts/view.go Outdated Show resolved Hide resolved

space-cli/cmd/modules/accounts/commands.go Outdated Show resolved Hide resolved

KavishShah09 added 12 commits May 23, 2020 18:34

fixed build issue

418a8e0

made change according to review

638a842

Merge branch 'v0.19.0' of https://github.com/spaceuptech/space-cloud …

4bccd4b

…into accounts-crud

Added windows specific env variables in tests

dfc5bd1

updated view function

9f1ba48

set account command

97b3a56

fixed lint issue

b7c0192

delete account command

703bc15

can set account with prefix

eeac766

minor change

af67a4d

changes made after manual testing

9b2f5f9

minor fix

f11db70

YourTechBud requested changes May 25, 2020

View reviewed changes

space-cli/cmd/modules/accounts/set.go Outdated Show resolved Hide resolved

space-cli/cmd/modules/accounts/set.go Outdated Show resolved Hide resolved

space-cli/cmd/modules/accounts/set.go Outdated Show resolved Hide resolved

space-cli/cmd/utils/file.go Outdated Show resolved Hide resolved

KavishShah09 added 2 commits May 25, 2020 17:41

changes acc to review

aefe08f

lower case

7a323a3

sharadregoti suggested changes May 26, 2020

View reviewed changes

KavishShah09 added 2 commits May 26, 2020 18:00

made requested changes and added test files for view and delete

66bb73d

set test file

0001eff

YourTechBud requested changes May 26, 2020

View reviewed changes

KavishShah09 added 2 commits May 27, 2020 02:10

Merge branch 'v0.19.0' of https://github.com/spaceuptech/space-cloud …

a83c899

…into accounts-crud

changes acc to review

a2182c6

KavishShah09 changed the title ~~WIP: space-cli commands to view, change and delete accounts~~ space-cli commands to view, change and delete accounts May 26, 2020

KavishShah09 requested review from YourTechBud and sharadregoti May 28, 2020 10:02

sharadregoti suggested changes May 28, 2020

View reviewed changes

changes requested

b864d24

KavishShah09 requested a review from sharadregoti May 28, 2020 12:58

YourTechBud previously requested changes Jun 1, 2020

View reviewed changes

space-cli/cmd/modules/accounts/set.go Outdated Show resolved Hide resolved

space-cli/cmd/modules/accounts/view.go Outdated Show resolved Hide resolved

KavishShah09 added 3 commits June 2, 2020 01:09

made requested changes

74280f9

Merge branch 'v0.19.0' of https://github.com/spaceuptech/space-cloud …

b20e11e

…into accounts-crud

fixed lint issue

8a3ae42

KavishShah09 requested a review from YourTechBud June 1, 2020 19:52

sharadregoti approved these changes Jun 6, 2020

View reviewed changes

sharadregoti suggested changes Jun 6, 2020

View reviewed changes

space-cli/cmd/modules/accounts/view.go Outdated Show resolved Hide resolved

space-cli/cmd/modules/accounts/commands.go Outdated Show resolved Hide resolved

space-cli/cmd/modules/accounts/commands.go Show resolved Hide resolved

requested changes

8f4b098

KavishShah09 requested a review from sharadregoti June 6, 2020 10:30

fixes

6d6c44d

sharadregoti previously approved these changes Jun 6, 2020

View reviewed changes

fixes

3f756d0

sharadregoti dismissed their stale review via 3f756d0 June 6, 2020 15:17

sharadregoti removed the request for review from YourTechBud June 6, 2020 15:30

sharadregoti approved these changes Jun 6, 2020

View reviewed changes

sharadregoti merged commit 5ea23a5 into spacecloud-io:v0.19.0 Jun 6, 2020

sharadregoti mentioned this pull request Jun 7, 2020

Add space-cli commands to view, change and delete accounts #1021

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

space-cli commands to view, change and delete accounts #1024

space-cli commands to view, change and delete accounts #1024

KavishShah09 commented May 23, 2020

sharadregoti left a comment

YourTechBud commented May 26, 2020

sharadregoti commented Jun 5, 2020

space-cli commands to view, change and delete accounts #1024

space-cli commands to view, change and delete accounts #1024

Conversation

KavishShah09 commented May 23, 2020

sharadregoti left a comment

Choose a reason for hiding this comment

YourTechBud commented May 26, 2020

sharadregoti commented Jun 5, 2020