-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spr diff
doesn't GPG sign commits.
#64
Comments
spr diff
doesn't GPG sign commits.
Yeah, this is a blocker for us because we require signed commits :( |
does this plan on getting addressed? |
Same here! |
So sad, it's a really wonderful tool but no support for it is a deal breaker. |
I managed to "fix" it using I've tested the generated binary, and it was working successfully 🎉. I've included in the pub fn commit(
repo: &git2::Repository,
author: &git2::Signature<'_>,
committer: &git2::Signature<'_>,
message: &str,
tree: &git2::Tree<'_>,
parents: &[&git2::Commit<'_>],
sign: Option<impl Sign>,
) -> std::result::Result<Oid, git2::Error> {
if let Some(sign) = sign {
let content = repo.commit_create_buffer(author, committer, message, tree, parents)?;
let content = std::str::from_utf8(&content).unwrap();
let signed = sign.sign(content)?;
repo.commit_signed(content, &signed, None)
} else {
repo.commit(None, author, committer, message, tree, parents)
}
} And every let new_oid = Self::commit(
&repo,
…
UserSign::from_config(&repo, &repo.config()?).ok()
)?; I've not been able to use the built-in The complete modification is available in that branch Without this issue, I think a PR would be trivial to do to improve the project. |
@joneshf reported this in #61
The text was updated successfully, but these errors were encountered: