Book: add mdbook preprocessor for embedded mermaid diagrams #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 22, 2022 11:26
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1 [skip ci]
Created using spr 1.3.5-beta.1
|
With the temporary changes in this PR (which includes the new Markdown file from #126 and an additional trigger in the GitHub Actions workflow to build the book for this PR), I could verify that this is working. I checked https://getcord.github.io/spr/reference/how-it-works-simple.html: |
added 4 commits
September 22, 2022 11:40
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
added 2 commits
September 22, 2022 13:24
Created using spr 1.3.5-beta.1 [skip ci]
flooey
approved these changes
Sep 22, 2022
sven-of-cord
changed the base branch from
spr/sven-of-cord/master.book-add-mdbook-preprocessor-for-embedded-mermaid-diagrams
to
master
sven-of-cord
deleted the
spr/sven-of-cord/book-add-mdbook-preprocessor-for-embedded-mermaid-diagrams
branch
clarityflowers
pushed a commit
to clarityflowers/spr
that referenced
this pull request
Mar 19, 2024
This is needed for spacedentist#126, which adds a new page that uses mermaid diagrams. I reworked the book workflow a little, now using the GitHub cache action to speed things up. Test Plan: after submitting this PR, I will update it with temporary modifications to GitHub workflow and docs to test this. If all is well, I remove those temporary changes again Reviewers: jozef-mokry, flooey Reviewed By: flooey Pull Request: spacedentist#141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #126, which adds a new page that uses mermaid diagrams.
I reworked the book workflow a little, now using the GitHub cache action to speed things up.
Test Plan:
after submitting this PR, I will update it with temporary modifications to GitHub workflow and docs to test this. If all is well, I remove those temporary changes again