Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1252] Hidden files will now be 50% opacity. #1548

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[ENG-1252] Hidden files will now be 50% opacity. #1548

merged 4 commits into from
Oct 16, 2023

Conversation

Tilo-K
Copy link
Contributor

@Tilo-K Tilo-K commented Oct 12, 2023

Hidden files will now be grayscale and at 50% opacity. In Media-View no grayscale is applied to not mess with the image.

gridview example
listview example

Closes #1514

@Tilo-K Tilo-K requested a review from a team as a code owner October 12, 2023 18:25
@vercel
Copy link

vercel bot commented Oct 12, 2023

@Tilo-K is attempting to deploy a commit to the Spacedrive Team on Vercel.

A member of the Team first needs to authorize it.

@jamiepine
Copy link
Member

opacity is fine, grayscale looks wrong, without the blue shift it sticks out against our color scheme

@Tilo-K
Copy link
Contributor Author

Tilo-K commented Oct 13, 2023

I removed the grayscale

Screenshot 2023-10-13 202541

@PineappleRind
Copy link
Contributor

Finder also dims the text, what do you think

image

@Tilo-K
Copy link
Contributor Author

Tilo-K commented Oct 13, 2023

Actually, I like this more yes

image

@Tilo-K Tilo-K changed the title [ENG-1252] Hidden files will now be grayscale and at 50% opacity. [ENG-1252] Hidden files will now be 50% opacity. Oct 13, 2023
@ameer2468 ameer2468 added this pull request to the merge queue Oct 16, 2023
@ameer2468
Copy link
Contributor

Thank you for your contribution, looks great!

Merged via the queue into spacedriveapp:main with commit d1e6f08 Oct 16, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENG-1252] Make hidden files slightly faded
4 participants