[ENG-1740] Add sempahore for generating sync operation timestamps #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
oscartbeaumont
approved these changes
Apr 16, 2024
Brendonovich
deleted the
eng-1740-timestamps-of-backfill-operations-could-be-newer-than-other
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When backfilling sync operations, we need to pause generating timestamps until backfill is complete in order to ensure that backfill operations have a lower timestamp than newer operations that are queued to occur after generating timestamps. This PR implements that by locking sync timestamp generation behind a semaphore that's used both when writing realtime operations and backfilling.