Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-95] Tags support & more #2494

Merged
merged 16 commits into from
May 17, 2024
Merged

[MOB-95] Tags support & more #2494

merged 16 commits into from
May 17, 2024

Conversation

ameer2468
Copy link
Contributor

@ameer2468 ameer2468 commented May 17, 2024

This PR does the following:

  • Various UI fixes, in filters page for scrolling locations and tags, and in locations and tags pages.
  • Add/remove tags from objects
  • Tags show in the explorer of Grid/list views
  • Clicking on search from a location or a tag will add the appropriate search filter
  • List view visual improvements
  • Overview, library size added.
  • Ericson gave me Rust code to make tags data is sent to FE correctly.
  • Tags explorer is now working - however with useObjects query we get orphan objects (Ericson thinks so), so I switched to Path for now, and it works fine.

Issues:

Spoke to @fogodev about this - when you initially add a location on mobile or desktop, and then you try to tag a Folder/dir specifically, the update will not show immediately unless you refresh that location. There's an issue on the BE.

Frame 1

@ameer2468 ameer2468 requested review from a team as code owners May 17, 2024 11:56
Copy link

linear bot commented May 17, 2024

MOB-95 Tags support

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 3:55pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 3:55pm

utkubakir
utkubakir previously approved these changes May 17, 2024
Copy link
Collaborator

@utkubakir utkubakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@ameer2468 ameer2468 added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 9d47af8 May 17, 2024
12 checks passed
@ameer2468 ameer2468 deleted the mob-95-tags-support branch May 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants