Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix @rpath/libswiftCore.dylib error + etc #255

Merged
merged 1 commit into from Jun 19, 2022
Merged

fix @rpath/libswiftCore.dylib error + etc #255

merged 1 commit into from Jun 19, 2022

Conversation

oscartbeaumont
Copy link
Member

Changes:

  • Fix main not compiling on macOS due to swift-rs issues.
    • The app would crash with an error containing dyld[17517]: Library not loaded: @rpath/libswiftCore.dylib.
  • Update Tauri to v1
  • Ensure consistency between tauri.config.json and tauri.linux.config.json
  • Make CI typechecks pass

Please ensure @jamiepine has reviewed this PR before merging as I changed the app bundle identifier to com.spacedrive.desktop as it was both co.spacedrive.desktop and app.spacedrive.desktop in the existing configuration.

@vercel
Copy link

vercel bot commented Jun 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
spacedrive-landing ✅ Ready (Inspect) Visit Preview Jun 18, 2022 at 5:39PM (UTC)
spacedrive-storybook ✅ Ready (Inspect) Visit Preview Jun 18, 2022 at 5:39PM (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview Jun 18, 2022 at 5:39PM (UTC)

@jamiepine jamiepine merged commit f8de1a8 into main Jun 19, 2022
Brendonovich pushed a commit that referenced this pull request Jun 21, 2022
@oscartbeaumont @Brendonovich
fix @rpath/libswiftCore.dylib error + etc (#255)
16ef266 
update Tauri + fix `@rpath/libswiftCore.dylib` error + make Typechecks pass
Brendonovich pushed a commit that referenced this pull request Jun 21, 2022
@oscartbeaumont @Brendonovich
fix @rpath/libswiftCore.dylib error + etc (#255)
7ff1eee 
update Tauri + fix `@rpath/libswiftCore.dylib` error + make Typechecks pass
Brendonovich pushed a commit that referenced this pull request Jun 25, 2022
@oscartbeaumont @Brendonovich
fix @rpath/libswiftCore.dylib error + etc (#255)
f943657 
update Tauri + fix `@rpath/libswiftCore.dylib` error + make Typechecks pass
lauer3912 pushed a commit to LabsRS-Ref/spacedrive that referenced this pull request Jul 10, 2022
Squashed commit of the following:
0608aea 
commit 58afabf
Author: Andre <34302688+CreatingBytes@users.noreply.github.com>
Date:   Wed Jun 22 14:23:57 2022 +0200

    Fixing Input.tsx ENG-144 (spacedriveapp#297)

    Update Input.tsx

    - Fixing the Line Height Issue ENG-144

commit 1b1a8c4
Author: Jamie Pine <ijamespine@me.com>
Date:   Wed Jun 22 04:40:45 2022 -0700

    (fix) job queue
    - adding a location performs all jobs
    - better logging for thumbnailer

commit ff9df3f
Author: Jamie Pine <ijamespine@me.com>
Date:   Wed Jun 22 04:13:11 2022 -0700

    (fix) notes: they work predictably
    - added lodash for debounce outside react tree
    - added command function to bridge
    - updated FAQ

commit d950a19
Author: jenniferdewan <45907677+jenniferdewan@users.noreply.github.com>
Date:   Tue Jun 21 23:04:39 2022 -0700

    Updates to ReadMe (spacedriveapp#286)

    1st change - This sentence should be combined because its format is like for X kinds of people Y program provides Z service. While I may have not explained it too well, these two sentences would flow better together.

    2nd change - The sentence makes more sense this way.

commit 281f6dd
Author: Bryan <bryandesigning@gmail.com>
Date:   Wed Jun 22 02:00:49 2022 -0400

    fix: track last file and force note saving on file change (spacedriveapp#288)

commit d11b9d0
Author: Jamie Pine <ijamespine@me.com>
Date:   Tue Jun 21 22:53:07 2022 -0700

    (chore): added better loggin

commit dd77aab
Author: Jamie Pine <ijamespine@me.com>
Date:   Tue Jun 21 21:31:39 2022 -0700

    (fix) dropdown ui tweak + identifier code comments + add log

commit 6332e75
Author: Hesham Abourgheba <hisham.abourgheba@gmail.com>
Date:   Tue Jun 21 18:47:52 2022 +0300

    fix(landing): hide horizontal scroll (spacedriveapp#267)

commit b7d1a6d
Author: Jamie Pine <32987599+jamiepine@users.noreply.github.com>
Date:   Tue Jun 21 08:39:16 2022 -0700

    Fixed file creation date (spacedriveapp#274)

    Indexing files shows correct file creation date

commit 45e2613
Author: Jamie Pine <32987599+jamiepine@users.noreply.github.com>
Date:   Tue Jun 21 07:45:12 2022 -0700

    (fix) README: remove diagram

commit 7cffba2
Author: Jamie Pine <32987599+jamiepine@users.noreply.github.com>
Date:   Tue Jun 21 07:39:31 2022 -0700

    Identifier Exponential Lag (spacedriveapp#269)

    A little refactor of the identifier job to remove memory leak and improve performance.

commit 39bf670
Author: Jamie Pine <32987599+jamiepine@users.noreply.github.com>
Date:   Tue Jun 21 01:23:14 2022 -0700

    Better Inspector Scroll (spacedriveapp#266)

    (fix) inspector: better scroll

commit 99cfe1d
Merge: 77713ba 2630995
Author: Oscar Beaumont <oscar@otbeaumont.me>
Date:   Tue Jun 21 15:17:27 2022 +0800

    Merge pull request spacedriveapp#265 from CreatingBytes/main

    Update TeamMember.tsx

commit 77713ba
Author: xPolar <50601857+xPolar@users.noreply.github.com>
Date:   Mon Jun 20 21:14:05 2022 -0700

    Notes on files. (spacedriveapp#253)

    * Temp fix for build.rs

    * Note implementation

    * Notes work now, need to iron out some things.

    * Finish file notes.

    Co-authored-by: maxichrome <maxichrome@users.noreply.github.com>

    * Remove lodash debounce

    * Fix pnpm locl

    Co-authored-by: maxichrome <maxichrome@users.noreply.github.com>

commit 2630995
Author: CreatingBytes <34302688+CreatingBytes@users.noreply.github.com>
Date:   Mon Jun 20 21:24:29 2022 +0200

    Update TeamMember.tsx

    Set the margin to auto on the div container for the social links on the Teammember page.

commit f1ec5a1
Merge: 55e52eb af55f8d
Author: Benjamin Akar <benjaminakar2001@gmail.com>
Date:   Mon Jun 20 20:44:35 2022 +0200

    Merge pull request spacedriveapp#263 from spacedriveapp/eng-148-landing-lag-on-windows

    (fix) landing: Windows performance

commit af55f8d
Author: Jamie Pine <ijamespine@me.com>
Date:   Mon Jun 20 03:29:18 2022 -0700

    rasterize bloom :D

commit 0e2c2ae
Author: Jamie Pine <ijamespine@me.com>
Date:   Mon Jun 20 01:34:27 2022 -0700

    remove bloom, network dev server

commit 55e52eb
Author: Oscar Beaumont <oscar@otbeaumont.me>
Date:   Mon Jun 20 11:27:37 2022 +0800

    fix clippy workflow (hopefully)

commit f8de1a8
Author: Oscar Beaumont <oscar@otbeaumont.me>
Date:   Sun Jun 19 08:00:57 2022 +0800

    fix `@rpath/libswiftCore.dylib` error + etc (spacedriveapp#255)

    update Tauri + fix `@rpath/libswiftCore.dylib` error + make Typechecks pass

commit 6cc52e5
Author: Oscar Beaumont <oscar@otbeaumont.me>
Date:   Sun Jun 19 01:52:03 2022 +0800

    remove frozen flag from cargo fetch

commit 48c61e6
Author: matt <30363562+mmattbtw@users.noreply.github.com>
Date:   Sat Jun 18 01:45:47 2022 -0700

    Made the open positions header appear in view (spacedriveapp#251)

commit 6978928
Author: Jamie Pine <32987599+jamiepine@users.noreply.github.com>
Date:   Sat Jun 18 01:35:51 2022 -0700

    Eng 142 fix interface hot reload (spacedriveapp#252)

    * fix interface hot reloading

    * AppPropsContext exsiting in App.tsx was the issue :D

    * type export fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brendonovich Brendonovich Brendonovich approved these changes

@jamiepine jamiepine Awaiting requested review from jamiepine

@maxichrome maxichrome Awaiting requested review from maxichrome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oscartbeaumont @Brendonovich @jamiepine