[Desktop, UI] Input, color picker improvements #633
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to Input:
string
- Shows label above input fieldstring | boolean
boolean
- Applies "error" classes to the fieldstring
- Applies "error" classes to the field and shows the error below the inputIcon | ReactNode
- Shows icon'left' | 'right'
default = 'left'
- Determine the position of the iconReactNode
- Add extra content on the right side of the inputstring
- Apply styles to the outer(parent) divstring
- Apply styles to the labelstring
- Apply styles to the iconstring
- Apply styles to the right contentThese changes remove reusable label code and fix input buttons clashing with the input.
Changes made to the color picker:
Changes made to useDialog:
closeOnSubmit: boolean
propdefault = true
- whether to close the dialog after the form has been submittedclose: () => void
prop - manually close the dialogChanges made to create tag form: