Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document soundness status #31

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Document soundness status #31

merged 2 commits into from
Aug 21, 2020

Conversation

autumnontape
Copy link
Contributor

I know it's been a while since there was a commit to this project, but I also know people are still on your case about this, and my hope is that full transparency will get them off of it. I'm also keeping in mind that you asked for a pull request in #30.

You'll need to publish a new version to crates.io, even if there have been no code changes, in order to make the textual changes since the last published version visible there and on docs.rs.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2020

CLA assistant check
All committers have signed the CLA.

@nox
Copy link

nox commented Jul 22, 2020

Full transparency would be making all methods that return a Completion unsafe. I already asked the author of this crate if they would approve a PR doing that but I've yet to get an answer back.

@autumnontape
Copy link
Contributor Author

@nox I agree that fixing the API would be ideal, but I also suspect that there will always be a set of crates that don't use unsafe as intended for one reason or another, and what's most important is being able to tell the difference right away.

@autumnontape
Copy link
Contributor Author

@spacejam Is rio abandoned?

@spacejam
Copy link
Owner

@autumnontape thanks for this PR! LGTM. rio is not abandoned, but I work on it as I have motivation to do so, and all of the negativity that people have dumped on me has basically dropped that motivation to 0 for the time being. As sled needs better io_uring support I'll support the features I benefit from, and if friendly folks care to push the codebase forward in ways that they will personally benefit from I'm more than happy to mentor them and work together, and that would probably also spark my motivation in general, because I get a lot of enjoyment out of sharing knowledge. So, for the time being, it's in a state of "waiting for motivation to come back" which probably won't happen until new people I haven't blocked yet stop making attacks on me in various places on the internet over this. In general I want to spend my energy on communities that engage respectfully with me and help to push things forward. Do a search on twitter for this crate's url and you'll see some really gross stuff. It's led to me feeling like the async subcommunity of rust is the most toxic group of humans I've ever had the misfortune of interacting with over technical matters, and it's made me spend more time on my database and distributed systems projects that let me engage with people who seem to be a nice intersection of {friendly, knowledgeable, measure what they use instead of rabidly spewing garbage}.

@spacejam spacejam merged commit 31e4f2f into spacejam:master Aug 21, 2020
Repository owner locked as resolved and limited conversation to collaborators Aug 21, 2020
@spacejam
Copy link
Owner

published

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants