fix failure to periodically flush after dropping a Db instance #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al high-level Arc to a Tree being dropped.
|
I have to say that I can't find another obvious deadlock that would lead to an issue in this particular scenario - the interface is such though that it is pretty easy to deadlock if the thread processing the subscription does anything else involving subscriptions, such as try to subscribe to another prefix. Maybe it would be best just to never block on the sending side and just use try_send? That or simply use a concurrent map as the registry so those locks don't have to be taken while sending is going on. |
spacejam
force-pushed
the
tyler_subscriber_send_lock
branch
from
d201c04
to
0a7061d
Compare
spacejam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the ongoing workspace for fixing the bug found in #1152