structured data support #1446
structured data support #1446
Conversation
There was a problem hiding this comment.
Left some comments.
Although in my case, I would generally do this as a wrapper around sled for storing serializable objects (which i would suggest instead of having it in sled directly), but what could be done to make it more uniform for other implementations around serde (eg bincode) would probably be to have 2 function pointer stored in Db that would call eg serde_json::to_vec and serde_json::from_slice (or in bincode case,bincode::serialize and bincode::deserialize) and have the functions be something like Db::insert_ser and Db::get_de (not the exact naming, but just throwing something out there) for anything related to serde under say a serde feature.
With that said, it might be best to look at #1266 and #1230
EDIT: Added links to issue and previous pr
| key: K, | ||
| value: &V, | ||
| ) -> Result<Option<IVec>> { | ||
| let value = serde_json::to_string(value).unwrap(); |
There was a problem hiding this comment.
Would be best not to unwrapping as that would result in a panic if it fails to serialize (you could probably use io::Error or just one of the other errors in result::Error). Also, wouldnt it be better to use serde_json::to_vec instead?
| ) -> Result<Option<T>> { | ||
| match self.db.get(key.as_ref())? { | ||
| Some(v) => { | ||
| let x = String::from_utf8(v.to_vec()).unwrap(); |
There was a problem hiding this comment.
You could grab the bytes and pass it to serde_json::from_slice instead
|
Hello - thank you for your interest in this, but I am going to close this PR because I would like sled to be completely ignorant of higher level formatting concerns for the forseeable future. |
Structured data type like struct, enum and others support added under the future "json" tested for window and linux I'm not sure about mac It's complicated for me to cross compile for it.