Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible support #307

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Ansible support #307

merged 4 commits into from
Jul 7, 2022

Conversation

michalg9
Copy link
Contributor

@michalg9 michalg9 commented Jul 7, 2022 •
edited

Description of the change

Add support for creating Ansible stacks.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • tfplugindocs has been run to make sure the docs are up to date.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer
  • The target branch is future unless the change is going directly into production

@marcinwyszynski
Copy link
Contributor

Task linked: CU-2kb5w8v [Ansible] Support stack creation in terraform provider

adamconnelly
adamconnelly previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just made a couple of suggestions for doc tweaks.

spacelift/data_stack.go Outdated Show resolved Hide resolved
spacelift/resource_stack.go Outdated Show resolved Hide resolved
@michalg9 @adamconnelly
Update spacelift/data_stack.go
ddd89c8 
Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>
@michalg9 @adamconnelly
Update spacelift/resource_stack.go
3ae5a9a 
Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>
@michalg9 michalg9 merged commit b5a3cdc into main Jul 7, 2022
@michalg9 michalg9 deleted the CU-2kb5w8v-ansible-support branch July 7, 2022 15:08
michalg9 added a commit that referenced this pull request Jul 8, 2022
@michalg9 @adamconnelly
Ansible support (#307)
779486b 
* Ansible support

* run tfplugindocs

* Update spacelift/data_stack.go

Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>

* Update spacelift/resource_stack.go

Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>

Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamconnelly adamconnelly adamconnelly approved these changes

@cube2222 cube2222 Awaiting requested review from cube2222

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalg9 @marcinwyszynski @adamconnelly