Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added default state importer for bitbucket_datacenter_integration #528

Merged
merged 2 commits into from
Mar 22, 2024
Merged

added default state importer for bitbucket_datacenter_integration #528

merged 2 commits into from
Mar 22, 2024

Conversation

truszkowski
Copy link
Contributor

Description of the change

Moved from: PR. Our tests rely on GitHub secrets, and they don't work with forks.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@Clickup-user
Copy link

Task linked: CU-86943rpxc take care of terraform-provider PR

@truszkowski truszkowski mentioned this pull request Mar 19, 2024
Closed
14 tasks
@truszkowski truszkowski force-pushed the CU-86943rpxc-importer-for-bitbucket-datacenter branch 2 times, most recently from 2f08e89 to 8384883 Compare March 19, 2024 11:10
@truszkowski truszkowski requested review from TheMacies, peterdeme and a team March 19, 2024 11:37
dependabot bot and others added 2 commits March 22, 2024 08:51
@dependabot @truszkowski
Bump google.golang.org/protobuf from 1.31.0 to 1.33.0
a5d8b44 
Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@mplushnikov @truszkowski
added default state importer for bitbucket_datacenter_integration
9bf0827 
added test for import bitbucket-datacenter resource
@truszkowski truszkowski force-pushed the CU-86943rpxc-importer-for-bitbucket-datacenter branch from 8384883 to 9bf0827 Compare March 22, 2024 07:52
@truszkowski truszkowski merged commit 787a6a9 into main Mar 22, 2024
7 checks passed
@truszkowski truszkowski deleted the CU-86943rpxc-importer-for-bitbucket-datacenter branch March 22, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

@peterdeme peterdeme peterdeme approved these changes

@TheMacies TheMacies Awaiting requested review from TheMacies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@truszkowski @Clickup-user @eliecharra @peterdeme @mplushnikov