Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for policy description #530

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

michieldewilde
Copy link
Contributor

@michieldewilde michieldewilde commented Mar 20, 2024

Description of the change

Moved from: PR. Our tests rely on GitHub secrets, and they don't work with forks.

Type of change

  • New feature (non-breaking change that adds functionality)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

sephriot
sephriot previously approved these changes Mar 21, 2024
@michieldewilde michieldewilde merged commit 2993eb7 into main Mar 21, 2024
7 checks passed
@michieldewilde michieldewilde deleted the add-support-for-policy-description branch March 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants