Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash in targetBaseEndpoint for vcs agent config #45

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

tomasmik
Copy link
Contributor

@tomasmik tomasmik commented Apr 12, 2023

Description of the change

Remove the trailing slash from the targetBaseEndpoint

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality not to work as expected);
  • Other (miscellaneous, GitHub workflow changes, changes to the PR template);

Checklists

Development

  • Lint rules pass locally;
  • All tests related to the changed code pass in development;

Code review

  • This pull request has a descriptive title and sufficient context for a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer a draft;

Deployment

  • Selected merge strategy is squash merge;
  • Changes have been reviewed by at least one other engineer;

@tomasmik tomasmik self-assigned this Apr 12, 2023
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thought - we could use url.Parse to ensure it's a valid URL, and also make sure it's in the correct format that we need. But I'm happy with just trimming the end of the string, so no worries if you don't think that makes sense.

@tomasmik tomasmik merged commit 0321bd0 into main Apr 13, 2023
@tomasmik tomasmik deleted the cu-862jgm94c-remove-trailing-slash branch April 13, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants