Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate uploads of Salmon Run jobs previously uploaded by s3s #45

Closed
AAGaming00 opened this issue Nov 29, 2022 · 3 comments · Fixed by #46
Closed

Duplicate uploads of Salmon Run jobs previously uploaded by s3s #45

AAGaming00 opened this issue Nov 29, 2022 · 3 comments · Fixed by #46
Assignees
Labels
bug Something isn't working

Comments

@AAGaming00
Copy link

AAGaming00 commented Nov 29, 2022

Describe the bug
I've been running s3s for the past few weeks, and wanted to give s3si.ts a go for its rank tracking. After starting the docker container, I noticed it started trying to upload 50 salmon run jobs, and after stopping it and checking one, I had noticed that it was uploading duplicates of jobs s3s had uploaded.

This can be observed on my stat.ink profile here

Interestingly, those uploaded by s3si.ts also seem to be missing the rank before (showing ? -> whatever rank whereas s3s shows the data, possibly related to the below error?), and are missing the weapon list on the Salmon Log page, but not in the full details page.

At some point, I also started getting spam of the following error:

Body:  { error: { title_exp_before: "Title Exp Before must be no less than 0." } }
Failed to export to stat.ink: Error: Failed to export battle
    at StatInkAPI.postCoop (file:///app/src/exporters/stat.ink.ts:136:13)
    at async StatInkExporter.exportGame (file:///app/src/exporters/stat.ink.ts:294:23)
    at async step (file:///app/src/app.ts:372:22)
    at async App.exportGameList (file:///app/src/app.ts:394:9)
Exported stat.ink: 0
    at async showError (file:///app/src/utils.ts:75:12)
    at async Promise.all (index 0)
    at async App.exportOnce (file:///app/src/app.ts:231:7)
    at async App.monitor (file:///app/src/app.ts:296:7)
    at async App.run (file:///app/src/app.ts:332:7)
    at async showError (file:///app/src/utils.ts:75:12)

I am unsure if this happens with normal games too as I quickly killed s3si.ts after noticing this

To Reproduce
Steps to reproduce the behavior:

  1. Use s3s to upload some salmon run jobs
  2. Run s3si
  3. Notice logs showing duplicated salmon run uploads
  4. See these uploaded on stat.ink

Expected behavior
s3si.ts should skip jobs uploaded by s3s.

Screenshots or Links
If applicable, add screenshots or links to stat.ink to help explain your problem.

Environment (please complete the following information):

  • OS: Linux (Docker on arm64 using this repo's Dockerfile modified to use LukeChannings's deno-arm64 images)
  • Deno version 1.26.2
  • Version 0c916cc
@spacemeowx2
Copy link
Owner

frozenpandaman/s3s#79

It was a bug in s3s, and I am happy to add workaround to avoid duplicate export

@spacemeowx2
Copy link
Owner

For the second question, in the case of +20 -> 40 it is possible to promote (?). -> 40) or not (20 -> 40). Since context-based judgments have not been added yet, s3si.ts left it blank here. The s3s choice to assume that you always go from 20 -> 40, so there is a chance of inaccuracy.

image

@spacemeowx2
Copy link
Owner

spacemeowx2 commented Nov 30, 2022

Duplicate uploads and missing the weapon list should be fixed.

Please delete the old battles using scripts/delete-coop.ts and try again.

@spacemeowx2 spacemeowx2 added the bug Something isn't working label Nov 30, 2022
@spacemeowx2 spacemeowx2 self-assigned this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants