add admin service for checkpoint and recover rpc #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvonzero
force-pushed
the
add-checkpoint-rpc
branch
3 times, most recently
from
f9a32c7
to
441ac9f
Compare
countvonzero
force-pushed
the
add-checkpoint-rpc
branch
from
441ac9f
to
d98a590
Compare
countvonzero
changed the title
dshulyak
approved these changes
May 12, 2023
| } | ||
|
|
||
| message CheckpointStreamResponse { | ||
| bytes data = 1; |
There was a problem hiding this comment.
if we would use protobuf you could stream objects one by one (using oneof as a enum) seamlessly. so it the stream would be smth like:
{type=HEADER, {Layer: 10, Restory: 11}}
{type=ACCOUNT, {Principal: ...}}
{type=ATX, {ID: ...}}
and then not to hold every atx/account in memory - there is an iterator pattern, i used it for TransactionResults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.