Add peer info api #258
Merged
Add peer info api #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fasmat
approved these changes
Aug 17, 2023
piersy
force-pushed
the
piersy/add-peer-info-api
branch
from
d9bb300
to
f006d10
Compare
piersy
force-pushed
the
piersy/add-peer-info-api
branch
from
4c56ba2
to
f809e8d
Compare
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Aug 21, 2023
## Motivation Closes #4778 Note that this is in a draft state because it needs spacemeshos/api#258 to be merged and I guess a release of the API package, before it can be merged. I plan to remove the replace directive for the api in the mod file when, the api has been released. ## Changes Adds a new streaming API endpoint to the node service to return info about connected peers. Note this PR changes the PostProviderID field to be exported to allow for config to be easily serialised/deserialised in order to perform a deep copy. ## Test Plan Added a test, the test doesn't check whether tags are since that part would make things a bit trickier. However through manual checking I can see that tags are being assigned. ```shell $ grpc_cli call localhost:9092 spacemesh.v1.NodeService.PeerInfo '' connecting to localhost:9092 peers { id: "12D3KooWRkZMjGNrQfRyeKQC9U58cUwAfyQMtjNsupixkBFag8AY" connections { address: "/ip4/34.150.215.241/tcp/5000" uptime: "29.348584085s" outbound: true } tags: "bootnode" } Rpc succeeded with OK status ``` ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an API endpoint to retrieve information about peers.
Part of spacemeshos/go-spacemesh#4778