Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block page review #95

Closed
avive opened this issue Nov 26, 2020 · 1 comment
Closed

Block page review #95

avive opened this issue Nov 26, 2020 · 1 comment
Assignees

Comments

@avive
Copy link
Contributor

avive commented Nov 26, 2020

  • Title: specific details for this block -> Block [short_hash].
  • Subtitle: specific details for this block. -> Details.
  • Block Number - make 0 for now. This will be the index of the block in the layer once the api supports this.
  • Remove block end timestamp row.
  • Change block start timestamp label to block time.
  • Make the layer data item clickable to view this layer's page on click.
  • Make the epoch data item clickable to view the epoch's page on click.
  • Total Transactions -> Transactions.
  • Total Rewards -> Rewards.
  • Missing field: Smesher - The smesher who submitted this block to the mesh. Linkable to smesher's screen.
  • Finality: 0% if layer is bigger then verified layer number. 99% if layer is equal or smaller to verified layer number.
  • Total rewards data item: numerical. If no rewards then display 0 instead of --.
  • Total rewards value data item. Units is coin. If 0 then display 0 SMH instead of --.
  • Hash - display full block hash but w/o all the trailing 0s.
  • Callout area: Total Coin Rewards: - remove : from label (like we did for all other screens). txns -> Transactions.
  • Fix the number of transactions in callout. It is currently constant 000 even for a block with transactions. see: https://stage-explore.spacemesh.io/blocks/0x58163b6e2fed2130bbbeabb2f3a4e99202d5ac3e000000000000000000000000
@despablos
Copy link
Contributor

despablos commented Dec 1, 2020

Fixed all, except:

1. Missing field: Smesher - The smesher who submitted this block to the mesh. Linkable to smesher's screen.
2. Hash - display full block hash but w/o all the trailing 0s.
3. Fix the number of transactions in callout. It is currently constant 000 even for a block with transactions. see: https://stage-explore.spacemesh.io/blocks/0x58163b6e2fed2130bbbeabb2f3a4e99202d5ac3e000000000000000000000000

This issues will be fixed, after back-end fix.

despablos added a commit that referenced this issue Dec 1, 2020
@avive avive closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants