Improve DB tests (#5508)

## Motivation

This PR improves two tests in the `sql` package that are currently required to be updated every time a new migration is added. Instead the tests are now self contained and don't fail after adding a migration.

sql/database_test.go

@@ -128,14 +128,26 @@ func TestDatabaseSkipMigrations(t *testing.T) {
 
 func TestDatabaseVacuumState(t *testing.T) {
 	dir := t.TempDir()
+
+	ctrl := gomock.NewController(t)
+	migration1 := NewMockMigration(ctrl)
+	migration1.EXPECT().Order().Return(1).AnyTimes()
+	migration1.EXPECT().Apply(gomock.Any()).Return(nil).Times(1)
+
+	migration2 := NewMockMigration(ctrl)
+	migration2.EXPECT().Order().Return(2).AnyTimes()
+	migration2.EXPECT().Apply(gomock.Any()).Return(nil).Times(1)
+
 	dbFile := filepath.Join(dir, "test.sql")
-	db, err := Open("file:" + dbFile)
+	db, err := Open("file:"+dbFile,
+		WithMigrations([]Migration{migration1}),
+	)
 	require.NoError(t, err)
 	require.NoError(t, db.Close())
 
 	db, err = Open("file:"+dbFile,
-		WithMigrations([]Migration{}),
-		WithVacuumState(10),
+		WithMigrations([]Migration{migration1, migration2}),
+		WithVacuumState(2),
 	)
 	require.NoError(t, err)
 	require.NoError(t, db.Close())

sql/migrations_test.go

@@ -1,6 +1,7 @@
 package sql
 
 import (
+	"slices"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -15,5 +16,11 @@ func TestMigrationsAppliedOnce(t *testing.T) {
 		return true
 	})
 	require.NoError(t, err)
-	require.Equal(t, version, 10)
+
+	migrations, err := StateMigrations()
+	require.NoError(t, err)
+	expectedVersion := slices.MaxFunc(migrations, func(a, b Migration) int {
+		return a.Order() - b.Order()
+	})
+	require.Equal(t, expectedVersion.Order(), version)
 }