-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerhub tag name is reused, potentially causing issues #2328
Comments
The CI run in question is here: https://github.com/spacemeshos/go-spacemesh/actions/runs/641165445, in which a branch that broke the system tests was somehow merged by bors anyway. I'll go ahead and paste the raw output of the two dockerpush commands that run, just for reference. I know @noamnelke already checked this, but you can see here that the commithash in both matches and is what we expect, Pushing to staging (from bors):
Pushing to develop (after bors):
|
I've also confirmed that both the time and the hash of the image currently on dockerhub for However, I can't check if the same is true of the |
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
## Motivation Closes #2328 ## Changes For staging branch, i.e., for `bors merge` runs, use commithash rather than branch name (`staging`) as docker image tag to ensure that bors is running tests against the right code ## Test Plan N/A
Description
System tests use an image on Dockerhub that's overwritten with different code each time. When using bors, it's always either
spacemeshos/go-spacemesh-dev:staging
orspacemeshos/go-spacemesh-dev:trying
and for local runs it's an image with the name of the branch.This could cause issues, because when running the tests we rely on the assumption that the image there is up to date and there are edge cases where it wouldn't be.
Affected code
This issue appears in commit hash:
f156138
Related files (optionally with line numbers):
go-spacemesh/Makefile
Lines 232 to 235 in f156138
The text was updated successfully, but these errors were encountered: