Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: support log collection from external smeshers #3134

Closed
Tracked by #130
dshulyak opened this issue Feb 20, 2022 · 1 comment
Closed
Tracked by #130

logging: support log collection from external smeshers #3134

dshulyak opened this issue Feb 20, 2022 · 1 comment

Comments

@dshulyak
Copy link
Contributor

We are missing important information that are required to troubleshoot concurrency-related issues. For instance in devnet220 in layer 8345 there are 2 proposals that are created with old base ballots and without votes for recent layers. It indicates that the hare didn't complete on those smeshers, while the rest of the cluster completed hare successfully.

There are two options:

  1. Integrate https://github.com/elastic/beats/tree/main/libbeat into spacemesh binary
  2. Integrate https://github.com/elastic/beats/tree/main/filebeat as a daemon, and manage that daemon from smapp

I prefer to go with 1st option

@dshulyak
Copy link
Contributor Author

With loki there is simpler version of the client . it needs to be integrated as a WriteSyncer to zap.Core . The client itself batches log entries in the background and instrumented with relevant metrics, so that we will know if logger will use a lot of traffic.

@dshulyak dshulyak added the log label Feb 22, 2022
bors bot pushed a commit that referenced this issue Aug 5, 2022
## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
part of #3134
<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
using systests TestAddNodes as measurement of the log file for a node.

- before 4.3M
- with hare reduced 1.6M (1st commit) (-62.79%)
- with the rest of the change 1.2M (-9.3%)
@pigmej pigmej unassigned evt Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

No branches or pull requests

2 participants