Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signer: use genesis id as domain separator for protocol messages #3503

Closed
dshulyak opened this issue Aug 27, 2022 · 0 comments
Closed

signer: use genesis id as domain separator for protocol messages #3503

dshulyak opened this issue Aug 27, 2022 · 0 comments
Assignees
@evt

Comments

@dshulyak
Copy link
Contributor

dshulyak commented Aug 27, 2022 •
edited

part of: spacemeshos/pm#135
depends on: #3505

https://github.com/spacemeshos/go-spacemesh/blob/develop/signing/signer.go

  • initialize EdSigner with GenesisID (preferably pass as an option to NewEdSigner/NewEdSignerFromBuffer/NewEDVerifier)
  • prefix message that is to be signed and verified with GenesisID
@evt evt assigned evt and unassigned evt Sep 1, 2022
@WilfredTA WilfredTA mentioned this issue Sep 12, 2022
Closed
19 tasks
This was referenced Sep 25, 2022
Closed
Closed
@dshulyak dshulyak mentioned this issue Sep 28, 2022
Closed
bors bot pushed a commit that referenced this issue Sep 30, 2022
@dshulyak
implement signer and verifier that prefixes message (#3599)
810831f 
closes: #3503

- added option to prefix message before signing and verifying
- signing.ExtractPublicKey replaced ed25519.ExtractPublicKey, so that we can use prefixed verifier

more efficient version won't allocate new buffer when message is being prefixed, but that requires changes in spacemesh/ed25519 library
@bors bors bot closed this as completed in bef8c97 Sep 30, 2022
@pigmej pigmej mentioned this issue Oct 11, 2022
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evt evt

Labels
None yet
Projects
Dev team kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - implement signer and verifier that prefixes message dshulyak/go-spacemesh
2 participants
@evt @dshulyak