-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch all LevelDB stores in unit tests to memory database #441
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.3 ETH (36.27 USD @ $120.9/ETH) attached to it as part of the Spacemesh - https://spacemesh.io fund.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 10 months, 1 week from now. 1) alonp99 has been approved to start work. Hey, I would like to take this one :) Learn more on the Gitcoin Issue Details page. 2) techswappy has applied to start work (Funders only: approve worker | reject worker). Familiar with in-memory database usage and how to migrate it. Can explore the codebase to understand the specific requirement here. Learn more on the Gitcoin Issue Details page. |
@antonlerner an integration test should be add instead in the start of it |
@alonp99 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@gitcoinbot working on it |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.3 ETH (34.74 USD @ $115.79/ETH) has been submitted by: @avive please take a look at the submitted work:
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 0.3 ETH (34.13 USD @ $113.78/ETH) attached to this issue has been approved & issued to @alonp99.
|
Overview / Motivation
We shouldn't use any persistent parts in our unit tests
The Task
Currently, we use database.NewLevelDbStore to create the DB for meshDB in the unit tests,
We should use only MemoryDB for unit tests.
Replace all occurrences of database.NewLevelDbStore in out unit tests to MemDatabase
Time Estimation
4 hours
Implementation Notes
check out block_listener_test.go
Contribution Guidelines
Important: Issue assignment to developers will be by the order of their application and proficiency level according to the tasks complexity. We will not assign tasks to developers who have'nt introduced themselves on our Gitter dev channel
develop
to your own repo and work in your repodevelop
The text was updated successfully, but these errors were encountered: