Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon: persist beacon protocol state and recover on startup #4583

Open
dshulyak opened this issue Jun 23, 2023 · 2 comments
Open

beacon: persist beacon protocol state and recover on startup #4583

dshulyak opened this issue Jun 23, 2023 · 2 comments

Comments

@dshulyak
Copy link
Contributor

i think there are two important events when we should persist:

  • after proposals and first round votes were received
  • on shutdown

we should also drop persisted data, when

  • node starts
  • epoch completes (or next starts)
@countvonzero
Copy link
Contributor

as per research discussion on Aug 28. because windows doesn't currently do graceful shutdown #4909

the proposal is modified to persist state periodically (every round)

@mathcrypto
Copy link

So the goal is to drop all persisted data at end of epoch N? How would that impact epoch N+1 to retrieve beacon from epoch N?

bors bot pushed a commit that referenced this issue Sep 27, 2023
## Motivation
disable beacon protocol until #4989 and #4583 are fixed

## Changes
set RoundsNumber == 0 to disable beacon protocol and not listen to beacon gossip

## TODO
- [x] Update [changelog](../CHANGELOG.md) as needed
- [x] test on devnet-406-short
bors bot pushed a commit that referenced this issue Sep 27, 2023
## Motivation
disable beacon protocol until #4989 and #4583 are fixed

## Changes
set RoundsNumber == 0 to disable beacon protocol and not listen to beacon gossip

## TODO
- [x] Update [changelog](../CHANGELOG.md) as needed
- [x] test on devnet-406-short
@dshulyak dshulyak assigned dshulyak and unassigned dshulyak Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants