Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: record latency only if object waasn't processed before #4623

Closed
dshulyak opened this issue Jul 1, 2023 · 1 comment
Closed

metrics: record latency only if object waasn't processed before #4623

dshulyak opened this issue Jul 1, 2023 · 1 comment
Assignees
@dshulyak
Labels
area/node

Comments

@dshulyak
Copy link
Contributor

dshulyak commented Jul 1, 2023

it slipped during initial review, we are not interested in recording time for duplicates that may appear after p2p evicts them from local cache. it messes up data

practically it means that latency should be recorded after as a last step in the processing pipeline
@dshulyak
Copy link
Contributor Author

dshulyak commented Jul 6, 2023

also we shouldn't record latency on the sync code path

@dshulyak dshulyak self-assigned this Aug 5, 2023
@dshulyak dshulyak mentioned this issue Sep 22, 2023
Closed
bors bot pushed a commit that referenced this issue Sep 28, 2023
@dshulyak
don't track latency for messages that are not gossipped futher (#5064)
56b4794 
this is mainly to prevent duplicates from skewing results. 
hare1 is not fixed in this change
latency metering is dropped for atx protocol, as we don't have good reference for it

closes: #4623
bors bot pushed a commit that referenced this issue Sep 28, 2023
@dshulyak
don't track latency for messages that are not gossipped futher (#5064)
b4a5b0b 
this is mainly to prevent duplicates from skewing results. 
hare1 is not fixed in this change
latency metering is dropped for atx protocol, as we don't have good reference for it

closes: #4623
@bors bors bot closed this as completed in ed0fe76 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dshulyak dshulyak

Labels
area/node
Projects
Dev team kanban
Archived in project
Milestone
No milestone
1 participant
@dshulyak