Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node configuration: fetch poet proofs from all poets in epoch 1 #4745

Closed
fasmat opened this issue Jul 25, 2023 · 0 comments
Closed

node configuration: fetch poet proofs from all poets in epoch 1 #4745

fasmat opened this issue Jul 25, 2023 · 0 comments
Assignees

Comments

@fasmat
Copy link
Member

fasmat commented Jul 25, 2023

Description

Due to a hardware issue no node was able to submit their proof to PoET 111. This PoET has been restored with the state of PoET 110. By default nodes only query poets for proof where they were successfully able to submit their challenge to.

For the upcoming end of the first PoET round (2023-08-06 8:00 UTC) this behaviour should be changed such that all nodes also query their proofs from PoET 111 instead of only from the ones they were able to submit to.

Implementation hints

  • getBestProof in nipost.go needs to be updated to have a different behavior for the end of the current PoET Round
    • instead of iterating over all submitted requests it should iterate over all known poets listed in the configuration
  • Add tests that verify that changed behavior works as expected for the current PoET round and reverts back to the current behavior after
@fasmat fasmat self-assigned this Jul 25, 2023
bors bot pushed a commit that referenced this issue Aug 1, 2023
## Motivation
Closes #4745 

## Changes
- When fetching a poet proof for the publish epoch 1 the state will be updated to duplicate the request for PoET 110 to PoET 111 such that the node will also try to fetch from there even if it didn't submit a proof to it.
- `NIPoSTBuilder` was updated to store clients in a map instead of in a slice for easier access.

## Test Plan
n/a

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors bors bot closed this as completed in 6a20160 Aug 1, 2023
bors bot pushed a commit that referenced this issue Aug 10, 2023
## Motivation
Closes #4753 

## Changes
This reverts the changes introduced with #4745 that were needed to make nodes query from all PoETs after the end of round 0. This workaround is not needed any more.

## Test Plan
n/a

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant