Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use a global logger in the poet client #4783

Closed
Tracked by #4751
poszu opened this issue Aug 7, 2023 · 0 comments
Closed
Tracked by #4751

Don't use a global logger in the poet client #4783

poszu opened this issue Aug 7, 2023 · 0 comments
Assignees
@poszu
Labels
area/poet technical debt

Comments

@poszu
Copy link
Contributor

poszu commented Aug 7, 2023 •
edited

Description

Currently, the poet client uses a global logger.

Affected code

https://github.com/spacemeshos/go-spacemesh/blob/develop/activation/poet.go

Acceptance criteria

  • pass log.Log to HTTPPoetClient,
  • pass the logger to retryablehttp.Client too.
@poszu poszu self-assigned this Aug 7, 2023
@poszu poszu mentioned this issue Aug 7, 2023
Closed
This was referenced Sep 8, 2023
Closed
Open
bors bot pushed a commit that referenced this issue Sep 8, 2023
@poszu
4783 poet client logging (#4988)
5f02d52 
## Motivation
Part of  #4751 
Closes #4783

## Changes
- use local logger in poet clients
- provide the logger to `retryablehttp` to gain visibility on performed requests, retries, responses etc.
- cleanup poet test harness

## Test Plan
Existing tests pass
bors bot pushed a commit that referenced this issue Sep 8, 2023
@poszu
4783 poet client logging (#4988)
24286d1 
## Motivation
Part of  #4751 
Closes #4783

## Changes
- use local logger in poet clients
- provide the logger to `retryablehttp` to gain visibility on performed requests, retries, responses etc.
- cleanup poet test harness

## Test Plan
Existing tests pass
bors bot pushed a commit that referenced this issue Sep 8, 2023
@poszu
4783 poet client logging (#4988)
16f717e 
## Motivation
Part of  #4751 
Closes #4783

## Changes
- use local logger in poet clients
- provide the logger to `retryablehttp` to gain visibility on performed requests, retries, responses etc.
- cleanup poet test harness

## Test Plan
Existing tests pass
@poszu poszu added the area/poet label Sep 8, 2023
@bors bors bot closed this as completed in 900f5b5 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poszu poszu

Labels
area/poet technical debt
Projects
Dev team kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - 4783 poet client logging spacemeshos/go-spacemesh
1 participant
@poszu