Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner/oracle: use activeset from reference ballot #4837

Closed
dshulyak opened this issue Aug 14, 2023 · 0 comments
Closed

miner/oracle: use activeset from reference ballot #4837

dshulyak opened this issue Aug 14, 2023 · 0 comments

Comments

@dshulyak
Copy link
Contributor

dshulyak commented Aug 14, 2023

if node created reference ballot with graded activeset and later was restarted it will create an activeset from first block.
such ballots will be syntactically invalid as receiver will validate them according to the reference ballot, that used graded active set.

this needs to be fixed before next epoch begins, otherwise network will very likely die

the solution is to lookup activeset on a reference ballot that stored locally, there is already code for it.

@dshulyak dshulyak changed the title miner, oracle: use activeset from reference ballot miner/oracle: use activeset from reference ballot Aug 16, 2023
bors bot pushed a commit that referenced this issue Aug 20, 2023
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
bors bot pushed a commit that referenced this issue Aug 20, 2023
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
bors bot pushed a commit that referenced this issue Aug 20, 2023
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
bors bot pushed a commit that referenced this issue Aug 20, 2023
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
@bors bors bot closed this as completed in b23bc52 Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant