[Merged by Bors] - Add timeouts to GH actions workflow #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove first slack notification, this is unnecessary since this test is so quick
noamnelke
approved these changes
Oct 25, 2020
Agree. Took another quick look just now and I'm not sure. Here are some recent timeouts:
All of these failed right after Let's merge this and investigate further if the timeouts continue. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2020
## Motivation I've noticed that these tests hang sometimes, this should make our lives a little easier by timing out tests if they're obviously hanging. I reviewed the times of the last few successful runs of each job and added a pretty large buffer in these timeouts. (see, e.g., https://github.com/spacemeshos/go-spacemesh/runs/1294892834?check_suite_focus=true) ## Changes - Adds `timeout-minutes` to each workflow job (per https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes) - Removes initial slack notification, as it's redundant since this test is so quick anyway ## Test Plan N/A
|
Build failed:
|
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2020
## Motivation I've noticed that these tests hang sometimes, this should make our lives a little easier by timing out tests if they're obviously hanging. I reviewed the times of the last few successful runs of each job and added a pretty large buffer in these timeouts. (see, e.g., https://github.com/spacemeshos/go-spacemesh/runs/1294892834?check_suite_focus=true) ## Changes - Adds `timeout-minutes` to each workflow job (per https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes) - Removes initial slack notification, as it's redundant since this test is so quick anyway ## Test Plan N/A
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I've noticed that these tests hang sometimes, this should make our lives a little easier by timing out tests if they're obviously hanging. I reviewed the times of the last few successful runs of each job and added a pretty large buffer in these timeouts. (see, e.g., https://github.com/spacemeshos/go-spacemesh/runs/1294892834?check_suite_focus=true)
Changes
timeout-minutesto each workflow job (per https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes)Test Plan
N/A