[Merged by Bors] - Remove CI status badge from README #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamnelke
approved these changes
Nov 2, 2020
|
Something like this: The code for this is: [](https://github.com/spacemeshos/go-spacemesh/blob/develop/ci.md) |
|
We can maybe link to a section in that doc like this: You're lying! Your "CI: passing" badge is static and doesn't reflect the true status!We make use of bors to ensure that commits that break any of our tests cannot get merged to |
|
closed due to inactivity |
|
I think we still want this. Will finish now. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2021
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
lrettig
added a commit
that referenced
this pull request
Mar 30, 2021
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
lrettig
added a commit
that referenced
this pull request
Mar 30, 2021
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
lrettig
added a commit
that referenced
this pull request
Mar 30, 2021
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
lrettig
added a commit
that referenced
this pull request
Mar 31, 2021
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
lrettig
added a commit
that referenced
this pull request
Apr 1, 2021
## Motivation "CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading. @noamnelke you were right, I concede :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
"CI status" for the develop branch is not really well-defined since we don't actually run any CI tasks on the develop branch. Bors runs them on staging, then merges to develop. If we set the status badge to develop, as it is now, it shows "no status." If we set it to staging, it'll show the status of the last bors run, which may have failed (and not been merged), which is misleading.
@noamnelke you were right, I concede :)