[Merged by Bors] - implement genesis config #3600
Conversation
dshulyak
requested review from
countvonzero,
evt,
abergasov,
jonZlotnik and
fasmat
as code owners
| @@ -296,6 +299,31 @@ func (app *App) introduction() { | |||
|
|
|||
| // Initialize sets up an exit signal, logging and checks the clock, returns error if clock is not in sync. | |||
| func (app *App) Initialize() (err error) { | |||
| // ensure all data folders exist | |||
| err = filesystem.ExistOrCreate(app.Config.DataDir()) | |||
There was a problem hiding this comment.
for better usability maybe we should just go ahead to create the directory if it doesn't exist.
There was a problem hiding this comment.
but this function is creating a directory exactly in such case. did i miss your point?
There was a problem hiding this comment.
lol. my bad.
the error msg is "ensure folders exist" which misled me and prolly the operator. but i guess it'll print filesystem error to give the operator more hint.
cmd/node/node_test.go
Outdated
| GenesisTime: time.Now().Format(time.RFC3339), | ||
| }, | ||
| } | ||
| require.ErrorContains(t, app.Initialize(), "tortoise") |
There was a problem hiding this comment.
maybe you can start from DefaultTestConfig() and modify the genesis config and data dir so you don't hit the tortoise param error. see TestInitialize_BadTortoiseParams
There was a problem hiding this comment.
thanks, slipped from my mind
cmd/node/node_test.go
Outdated
| } | ||
|
|
||
| require.ErrorContains(t, app.Initialize(), "tortoise") | ||
| require.ErrorContains(t, app.Initialize(), "tortoise") |
|
bors try |
tryBuild succeeded: |
|
bors merge |
|
Build failed: |
|
bors merge |
|
Pull request successfully merged into develop. Build succeeded: |
bors
bot
changed the title
closes: #3505