Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - track gossip payload/messages by protocol #3798

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - track gossip payload/messages by protocol #3798

wants to merge 1 commit into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Nov 25, 2022 •
edited

related: #3459
close: #3305

@pigmej pigmej self-requested a review November 25, 2022 15:21
pigmej
pigmej approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@pigmej pigmej left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge +1 from my side to be able to asses better gossip.

One question though, would it be possible to add hare per type also? Like preroud, status, proposal etc?

@selfdual-brain selfdual-brain mentioned this pull request Nov 25, 2022
Closed
@dshulyak
Copy link
Contributor Author

One question though, would it be possible to add hare per type also? Like preroud, status, proposal etc?

due to the implementation it is not easy. but should be possible though with some additional hacks

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Nov 25, 2022
@dshulyak
track gossip payload/messages by protocol (#3798)
8701bb8 
related: #3459
close: #3305
@bors
Copy link

bors bot commented Nov 25, 2022

Pull request successfully merged into develop.

Build succeeded:

@bors bors bot changed the title track gossip payload/messages by protocol [Merged by Bors] - track gossip payload/messages by protocol Nov 25, 2022
@bors bors bot closed this Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pigmej pigmej pigmej approved these changes

@countvonzero countvonzero Awaiting requested review from countvonzero

@fasmat fasmat Awaiting requested review from fasmat fasmat is a code owner

@poszu poszu Awaiting requested review from poszu poszu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p2p: capture metrics for per-protocol gossip
2 participants
@dshulyak @pigmej