Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NaCl for authentication and encryption in P2P #462

Merged
merged 14 commits into from
Jan 22, 2019
Merged

Use NaCl for authentication and encryption in P2P #462

merged 14 commits into from
Jan 22, 2019

Conversation

noamnelke
Copy link
Member

No description provided.

@zalmen zalmen self-assigned this Jan 20, 2019
y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/cryptoBox/box.go Outdated Show resolved Hide resolved
y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/cryptoBox/box.go Outdated Show resolved Hide resolved
y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/dht/bootstrap.go Outdated Show resolved Hide resolved
y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/gossip/protocol.go Outdated Show resolved Hide resolved
y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/message/message.go Outdated Show resolved Hide resolved
y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/net/conn_test.go Outdated Show resolved Hide resolved
gavraz
gavraz reviewed Jan 20, 2019
View reviewed changes
Copy link
Contributor

@gavraz gavraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the hare protocol look ok (hare.go & hare_test.go).

y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/swarm.go Show resolved Hide resolved
y0sher
y0sher reviewed Jan 20, 2019
View reviewed changes
p2p/swarm.go Show resolved Hide resolved
antonlerner
antonlerner reviewed Jan 20, 2019
View reviewed changes
p2p/cryptoBox/box.go Outdated Show resolved Hide resolved
antonlerner
antonlerner reviewed Jan 20, 2019
View reviewed changes
p2p/cryptoBox/box.go Outdated Show resolved Hide resolved
@y0sher y0sher mentioned this pull request Jan 20, 2019
Closed
zalmen
zalmen suggested changes Jan 21, 2019
View reviewed changes
p2p/cryptoBox/box.go Outdated Show resolved Hide resolved
p2p/connectionpool/connectionpool.go Outdated Show resolved Hide resolved
p2p/net/network.go Outdated Show resolved Hide resolved
p2p/net/network.go Show resolved Hide resolved
p2p/net/session.go Show resolved Hide resolved
@noamnelke noamnelke merged commit 58e3023 into develop Jan 22, 2019
@noamnelke noamnelke deleted the persistent_key_encryption branch January 22, 2019 14:39
@y0sher y0sher restored the persistent_key_encryption branch May 29, 2019 18:44
@y0sher y0sher deleted the persistent_key_encryption branch May 30, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0sher y0sher y0sher left review comments

@gavraz gavraz gavraz left review comments

@antonlerner antonlerner antonlerner left review comments

@zalmen zalmen zalmen approved these changes

@almogdepaz almogdepaz Awaiting requested review from almogdepaz

Assignees

@zalmen zalmen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@noamnelke @y0sher @gavraz @zalmen @antonlerner @almogdepaz