Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smesher id to grpc reward object #4850

Closed
wants to merge 7 commits into from

Conversation

piersy
Copy link
Contributor

@piersy piersy commented Aug 15, 2023

Motivation

Closes - #4529

Changes

Adds the smesher ID into the reward responses from the AccountDataStream and GlobalStateStream. Notably this does not add the smesher ID into the reward responses from the AccountDataQuery endpoint because that loads rewards from the DB and currently the DB does not record the smesher ID.

Questions

This work was to allow the explorer to display rewards by smesher ID, the explorer can use this branch for now, does it make sense to merge this for everyone else before doing the work to migrate the DB?

On the flipside, will it cause problems having to maintain a fork for the explorer?

Test Plan

Updated the unit tests for the affected services

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #4850 (7179380) into develop (21c602e) will increase coverage by 76.9%.
The diff coverage is 100.0%.

❗ Current head 7179380 differs from pull request most recent head 7890737. Consider uploading reports for the commit 7890737 to get more accurate results

@@            Coverage Diff             @@
##           develop   #4850      +/-   ##
==========================================
+ Coverage         0   76.9%   +76.9%     
==========================================
  Files            0     261     +261     
  Lines            0   29728   +29728     
==========================================
+ Hits             0   22863   +22863     
- Misses           0    5416    +5416     
- Partials         0    1449    +1449     
Files Coverage Δ
api/grpcserver/globalstate_service.go 70.2% <100.0%> (ø)
common/types/block.go 65.0% <ø> (ø)
events/reporter.go 64.5% <ø> (ø)
genvm/vm.go 79.8% <100.0%> (ø)
mesh/executor.go 80.1% <100.0%> (ø)

... and 256 files with indirect coverage changes

@piersy piersy marked this pull request as ready for review August 16, 2023 14:47
@piersy piersy requested a review from kacpersaw August 16, 2023 14:49
@piersy piersy mentioned this pull request Aug 17, 2023
@spacemesh-bors spacemesh-bors bot closed this in d424b78 Dec 2, 2023
@fasmat fasmat deleted the piersy/add_smesher_id_to_grpc_reward_object branch January 17, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants