Add smesher id to grpc reward object #4850
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes - #4529
Changes
Adds the smesher ID into the reward responses from the AccountDataStream and GlobalStateStream. Notably this does not add the smesher ID into the reward responses from the AccountDataQuery endpoint because that loads rewards from the DB and currently the DB does not record the smesher ID.
Questions
This work was to allow the explorer to display rewards by smesher ID, the explorer can use this branch for now, does it make sense to merge this for everyone else before doing the work to migrate the DB?
On the flipside, will it cause problems having to maintain a fork for the explorer?
Test Plan
Updated the unit tests for the affected services
DevOps Notes