[Merged by Bors] - cache the right data #4858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4858 +/- ##
=========================================
- Coverage 76.9% 76.8% -0.1%
=========================================
Files 261 261
Lines 29720 29724 +4
=========================================
- Hits 22858 22857 -1
- Misses 5412 5416 +4
- Partials 1450 1451 +1
|
fasmat
approved these changes
Aug 16, 2023
|
bors merge |
|
bors cancel |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
## Motivation Closes #4842 ## Changes remove timestamp. it's no longer useful after we made update immutable, and it caused the code to cache the wrong suffix note: this is causing a node to query bootstrap url after restart.
|
Build failed:
|
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
## Motivation Closes #4842 ## Changes remove timestamp. it's no longer useful after we made update immutable, and it caused the code to cache the wrong suffix note: this is causing a node to query bootstrap url after restart.
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Motivation Closes #4842 ## Changes remove timestamp. it's no longer useful after we made update immutable, and it caused the code to cache the wrong suffix note: this is causing a node to query bootstrap url after restart.
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2023
## Motivation #4858 was not a backward compatible fix. explorer's node running with latest in develop crashed with ``` {"L":"INFO","T":"2023-08-18T16:28:53.473Z","N":"ff765.bootstrap","M":"loaded bootstrap file","node_id":"ff76543be7a1919e65ac9eac4739aa467b0e0baa202825a77b223fc9c791dc70","module":"bootstrap","persisted":"/root/data/node/bootstrap/2/epoch-2-update-bs-2023-08-10T06-00-08","epoch":"2","beacon":"0xe3e3389e","activeset_size":2367,"name":"bootstrap"} 1 {"L":"FATAL","T":"2023-08-18T16:28:53.473Z","N":"ff765.bootstrap","M":"unexpected suffix for fallback files","node_id":"ff76543be7a1919e65ac9eac4739aa467b0e0baa202825a77b223fc9c791dc70","module":"bootstrap","suffix":"08","name":"bootstrap"} ``` ## changes - rename legacy files with timestamp to the correct one ("epoch-2-update-bs-2023-08-10T06-00-08" -> "epoch-2-update-bs") - delete extra files ## testing - unit test - manually test with mainnet. sync a node with mainnet and restart multiple times so that there are multiple boostrap files for epoch 2. run new code and saw that only 1 file left "epoch-2-update-bs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4842
Changes
remove timestamp. it's no longer useful after we made update immutable, and it caused the code to cache the wrong suffix
note:
this is causing a node to query bootstrap url after restart.