Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - update changelog for #4879 #4929

Closed

Conversation

countvonzero
Copy link
Contributor

@countvonzero countvonzero commented Aug 30, 2023

Motivation

follow up on #4879 update changelog for release

also rename migration file to reflect its released state

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4929 (3f5cc08) into develop (391cb83) will increase coverage by 0.0%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #4929   +/-   ##
=======================================
  Coverage     76.7%   76.8%           
=======================================
  Files          256     256           
  Lines        29655   29665   +10     
=======================================
+ Hits         22774   22783    +9     
- Misses        5408    5409    +1     
  Partials      1473    1473           

see 8 files with indirect coverage changes

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 30, 2023
## Motivation
follow up on #4879 update changelog for release

also rename migration file to reflect its released state
@dshulyak
Copy link
Contributor

bors cancel

@bors
Copy link

bors bot commented Aug 30, 2023

Canceled.

@dshulyak
Copy link
Contributor

i think renaming migration will break node

@dshulyak
Copy link
Contributor

sorry, looks like only version matters, name is only for description

@dshulyak
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Aug 30, 2023
## Motivation
follow up on #4879 update changelog for release

also rename migration file to reflect its released state
@dshulyak
Copy link
Contributor

but honestly i don't understand why to include such changes with changelog update

@bors
Copy link

bors bot commented Aug 30, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title update changelog for #4879 [Merged by Bors] - update changelog for #4879 Aug 30, 2023
@bors bors bot closed this Aug 30, 2023
@countvonzero
Copy link
Contributor Author

but honestly i don't understand why to include such changes with changelog update

yes. sorry. will separate such change in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants