[Merged by Bors] - tortoise: don't use active set to compute number of expected ballots

[dshulyak]

closes: #4841

with this change active set is used only to verify eligibilities in the current epoch.
tortoise doesn't need to load activeset into the state, which is reflected in the accepted type

[codecov]

Codecov Report

Merging #5002 (7bcbb8a) into develop (290a03a) will increase coverage by 0.0%.
The diff coverage is 90.3%.

@@           Coverage Diff           @@
##           develop   #5002   +/-   ##
=======================================
  Coverage     77.1%   77.2%           
=======================================
  Files          254     254           
  Lines        30385   30351   -34     
=======================================
- Hits         23443   23432   -11     
+ Misses        5422    5399   -23     
  Partials      1520    1520           

Files Changed	Coverage Δ
common/types/ballot.go	51.8% <ø> (-0.3%)	⬇️
common/types/layer.go	82.5% <ø> (-0.7%)	⬇️
common/types/tortoise_data.go	0.0% <ø> (ø)
proposals/util.go	86.3% <ø> (ø)
proposals/util/util.go	76.9% <ø> (-2.4%)	⬇️
tortoise/state.go	97.3% <ø> (+1.0%)	⬆️
tortoise/sim/layer.go	88.9% <76.9%> (-1.6%)	⬇️
config/mainnet.go	95.8% <100.0%> (+<0.1%)	⬆️
miner/oracle.go	74.5% <100.0%> (+0.9%)	⬆️
node/node.go	63.1% <100.0%> (+<0.1%)	⬆️
... and 5 more

... and 6 files with indirect coverage changes

[countvonzero]

if you want, you can also just delete the hare active set grading all together and remove legacy layer.

[dshulyak]

if you want, you can also just delete the hare active set grading all together and remove legacy layer.

probably not in this change, but will do if i will be touching that code

[dshulyak]

bors merge

[bors]

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• ci-status
• systest-status