[Merged by Bors] - Return ATX version along with blob #5922
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5922 +/- ##
=======================================
Coverage 80.7% 80.7%
=======================================
Files 289 288 -1
Lines 29868 29890 +22
=======================================
+ Hits 24107 24141 +34
+ Misses 4164 4160 -4
+ Partials 1597 1589 -8 ☔ View full report in Codecov by Sentry. |
poszu
force-pushed
the
atxmerge/decoding-atxv2-blob
branch
from
e457400
to
f0743ac
Compare
| @@ -273,7 +273,10 @@ type ( | |||
| ) | |||
|
|
|||
| var loadBlobDispatch = map[Hint]loadBlobFunc{ | |||
| ATXDB: atxs.LoadBlob, | |||
| ATXDB: func(ctx context.Context, db sql.Executor, key []byte, blob *sql.Blob) error { | |||
| _, err := atxs.LoadBlob(ctx, db, key, blob) | |||
There was a problem hiding this comment.
We will need blob version handling in fetch client / server, but that can be done later, of course.
Initial syncv2 version will reuse current blob fetching mechanism
There was a problem hiding this comment.
Why would it need to care about the version here? The fetched blobs are pushed through the ATX handler which can figure out the version while decoding on its own.
|
bors merge |
## Motivation Need to get the ATX version from the `atx_blobs` table to decode ATX w/o knowing epoch->version mapping everywhere in the code.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Motivation
Need to get the ATX version from the
atx_blobstable to decode ATX w/o knowing epoch->version mapping everywhere in the code.Description
atxs.LoadBlob()also returns types.AtxVersionTest Plan
TODO